Remove GlobalToastList wrapper directive. Add onChange callback. #16375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
Team:Platform-Design
💔 Build Failed |
💚 Build Succeeded |
bmcconaghy
reviewed
Jan 30, 2018
| @@ -61,7 +61,7 @@ export default function ({ getService, getPageObjects }) { | |||
| expect(spyToggleExists).to.be(true); | |||
| }); | |||
|
|
|||
| it('should show correct tag cloud data', async function () { | |||
| it.skip('should show correct tag cloud data', async function () { | |||
There was a problem hiding this comment.
Should this be part of this PR?
There was a problem hiding this comment.
It was flaking out on me so I had to skip it. I recorded this in an issue here: #16383. The alternative would be to do this in master so we get a specific commit for this change, but I don't think that's necessary. What do you think?
There was a problem hiding this comment.
I'm OK with piggybacking it. Small change.
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Jan 30, 2018
…stic#16375) * Remove GlobalToastList wrapper directive. Add onChange callback. * Skip flaky tag cloud test.
cjcenizal
added a commit
that referenced
this pull request
Jan 30, 2018
) (#16405) * Remove GlobalToastList wrapper directive. Add onChange callback. * Skip flaky tag cloud test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some bugs we had earlier by removing this system's dependency upon Angular altogether.
CC @pickypg This might affect how you build your banner notifications system.